Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()

From	Kevin Hilman <khilman@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()
Date	2016-08-16 15:20 +0200
Message-ID	<s6MrE-3zL-9@gated-at.bofh.it> (permalink)
References	<s239M-2mN-45@gated-at.bofh.it> <s239M-2mN-43@gated-at.bofh.it>
Organization	BayLibre

Show all headers | View raw

Daniel Wagner <wagi@monom.org> writes:

> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
>   reinit_completion()
>   ...
>   /* Start the transfer */
>   ...
>   wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>

Acked-by: Kevin Hilman <khilman@baylibre.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all() Kevin Hilman <khilman@baylibre.com> - 2016-08-16 15:20 +0200

csiph-web