Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator
Date	2016-08-16 12:00 +0200
Message-ID	<s6Jk6-1sx-31@gated-at.bofh.it> (permalink)
References	<s5sbD-7aC-25@gated-at.bofh.it> <s6rGz-7aD-37@gated-at.bofh.it> <s6tyG-8mb-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 15, 2016 at 07:04:45PM +0200, Fabian Frederick wrote:
> 
> 
> > On 15 August 2016 at 17:05 Arnd Bergmann <arnd@arndb.de> wrote:
> >
> >
> > On Friday 12 August 2016, Fabian Frederick wrote:
> > > We can directly depend on SOC_IMX31 since
> > > commit c9ee94965dce
> > > ("ARM: imx: deconstruct mxc_rnga initialization")
> > >
> > > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> >
> > Did I cause a regression with my patch, without this change? If so, this
> > should be
> > marked
> >
> > Cc: stable@vger.kernel.org
> > Fixes: c9ee94965dce ("ARM: imx: deconstruct mxc_rnga initialization")
> >
> > and the patch applied ASAP.
> 
> Thanks Arnd. Your patch brings the following regression:
> CONFIG_HW_RANDOM_MXC_RNGA can't be switched on with an unknown symbol and
> mxc-rnga.o will never build with
> ARCH=arm make M=drivers/char/hw_random
> Before your patch, HW_RANDOM_MXC_RNGA required ARCH_HAS_RNGA
> which was based on IMX_HAVE_PLATFORM_MXC_RNGA  && ARCH_MXC
> IMX_HAVE_PLATFORM_MXC_RNGA  was based on SOC_IMX31.
> As I see SOC_IMX31 is selected by ARCH_MXC, my patch still seems ok and I can Cc
> it for stable.

Please resubmit the patch to linux-crypto@vger.kernel.org.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator Fabian Frederick <fabf@skynet.be> - 2016-08-12 23:30 +0200
  Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator Arnd Bergmann <arnd@arndb.de> - 2016-08-15 17:10 +0200
    Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random  Number Generator Fabian Frederick <fabf@skynet.be> - 2016-08-15 19:10 +0200
      Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random  Number Generator Herbert Xu <herbert@gondor.apana.org.au> - 2016-08-16 12:00 +0200

csiph-web