[PATCH 4/5] ACPI / sysfs: Fix an issue for LoadTable opcode

Path	csiph.com!goblin2!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Lv Zheng <lv.zheng@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/5] ACPI / sysfs: Fix an issue for LoadTable opcode
Date	Tue, 16 Aug 2016 11:00:01 +0200
Message-ID	<s6Io1-R5-23@gated-at.bofh.it> (permalink)
References	<s6Io1-R5-1@gated-at.bofh.it>
X-Original-To	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <len.brown@intel.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.28,529,1464678000"; d="scan'208";a="866159522"
X-Mailer	git-send-email 1.7.10
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	Lv Zheng <lv.zheng@intel.com>, Lv Zheng <zetalog@gmail.com>, <linux-kernel@vger.kernel.org>, linux-acpi@vger.kernel.org
X-Original-Date	Tue, 16 Aug 2016 16:53:08 +0800
X-Original-Message-ID	<95ab759477b67ba43862d686ff410efd8471fd33.1471337441.git.lv.zheng@intel.com>
X-Original-References	<cover.1471337441.git.lv.zheng@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1463561

Show key headers only | View raw

OEM tables can be installed via RSDT/XSDT, in this case, they have already
been created under /sys/firmware/acpi/tables.

For this kind of tables, normally LoadTable opcode will be executed to load
them. If LoadTable opcode is executed after acpi_sysfs_init(),
acpi_sysfs_table_handler() will be invoked, thus a redundant table file
will be created under /sys/firmware/acpi/tables/dynamic. Then running
"acpidump" on such platform results in an error.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=150841
Reported-by: Jason Voelz <jason.voelz@intel.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/sysfs.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
index 358165e..f2fa363 100644
--- a/drivers/acpi/sysfs.c
+++ b/drivers/acpi/sysfs.c
@@ -383,7 +383,7 @@ acpi_status acpi_sysfs_table_handler(u32 event, void *table, void *context)
 	struct acpi_table_attr *table_attr;
 
 	switch (event) {
-	case ACPI_TABLE_EVENT_LOAD:
+	case ACPI_TABLE_EVENT_INSTALL:
 		table_attr =
 		    kzalloc(sizeof(struct acpi_table_attr), GFP_KERNEL);
 		if (!table_attr)
@@ -397,7 +397,9 @@ acpi_status acpi_sysfs_table_handler(u32 event, void *table, void *context)
 		} else
 			list_add_tail(&table_attr->node, &acpi_table_attr_list);
 		break;
+	case ACPI_TABLE_EVENT_LOAD:
 	case ACPI_TABLE_EVENT_UNLOAD:
+	case ACPI_TABLE_EVENT_UNINSTALL:
 		/*
 		 * we do not need to do anything right now
 		 * because the table is not deleted from the
-- 
1.7.10

Thread

[PATCH 0/5] ACPI / sysfs: Cleanup sysfs table handling code Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  [PATCH 5/5] ACPI / sysfs: Update sysfs signature handling code Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  [PATCH 3/5] ACPICA: Tables: Add new table events indicating table installation/uninstallation Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  [PATCH 2/5] ACPICA: Tables: Remove wrong table event macros Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  [PATCH 1/5] ACPICA: Tables: Remove acpi_tb_install_fixed_table() Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  [PATCH 4/5] ACPI / sysfs: Fix an issue for LoadTable opcode Lv Zheng <lv.zheng@intel.com> - 2016-08-16 11:00 +0200
  Re: [PATCH 0/5] ACPI / sysfs: Cleanup sysfs table handling code "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-16 13:40 +0200
    Re: [PATCH 0/5] ACPI / sysfs: Cleanup sysfs table handling code "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-17 03:50 +0200
    RE: [PATCH 0/5] ACPI / sysfs: Cleanup sysfs table handling code "Zheng, Lv" <lv.zheng@intel.com> - 2016-08-17 03:50 +0200

csiph-web