[PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage
Date	2016-08-16 10:30 +0200
Message-ID	<s6HUZ-EP-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

ret is not initialized so it contains garbage.  Ensure garbage
is not returned by initializing rc to 0.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/nvme/host/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 8d2875b..9c69393 100644
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1319,7 +1319,7 @@ out_destroy_queue_ib:
 static int nvme_rdma_device_unplug(struct nvme_rdma_queue *queue)
 {
 	struct nvme_rdma_ctrl *ctrl = queue->ctrl;
-	int ret;
+	int ret = 0;
 
 	/* Own the controller deletion */
 	if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_DELETING))
-- 
2.8.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvme-rdma: initialize ret to zero to avoid returning garbage Colin King <colin.king@canonical.com> - 2016-08-16 10:30 +0200
  Re: [PATCH] nvme-rdma: initialize ret to zero to avoid returning  garbage Sagi Grimberg <sagi@grimberg.me> - 2016-08-16 11:10 +0200

csiph-web