Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper
Date	Tue, 16 Aug 2016 08:20:02 +0200
Message-ID	<s6FTc-7TO-11@gated-at.bofh.it> (permalink)
References	<s4GgI-79-119@gated-at.bofh.it> <s4IBQ-1DK-45@gated-at.bofh.it>
X-Original-Senderip	156.147.1.126
X-Original-Mailfrom	iamjoonsoo.kim@lge.com
X-Original-Senderip	10.177.222.138
X-Original-Mailfrom	iamjoonsoo.kim@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, Michal Hocko <mhocko@kernel.org>, Mel Gorman <mgorman@techsingularity.net>, David Rientjes <rientjes@google.com>, Rik van Riel <riel@redhat.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 16 Aug 2016 15:15:18 +0900
X-Original-Message-ID	<20160816061518.GE17448@js1304-P5Q-DELUXE>
X-Original-References	<20160810091226.6709-1-vbabka@suse.cz> <20160810091226.6709-9-vbabka@suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1463440

Show key headers only | View raw

On Wed, Aug 10, 2016 at 11:12:23AM +0200, Vlastimil Babka wrote:
> Compaction uses a watermark gap of (2UL << order) pages at various places and
> it's not immediately obvious why. Abstract it through a compact_gap() wrapper
> to create a single place with a thorough explanation.
> 
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> Acked-by: Michal Hocko <mhocko@suse.com>
> ---
>  include/linux/compaction.h | 16 ++++++++++++++++
>  mm/compaction.c            |  7 +++----
>  mm/vmscan.c                |  6 +++---
>  3 files changed, 22 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/compaction.h b/include/linux/compaction.h
> index a1fba9994728..e7f0d34a90fe 100644
> --- a/include/linux/compaction.h
> +++ b/include/linux/compaction.h
> @@ -58,6 +58,22 @@ enum compact_result {
>  
>  struct alloc_context; /* in mm/internal.h */
>  
> +/*
> + * Number of free order-0 pages that should be available above given watermark
> + * to make sure compaction has reasonable chance of not running out of free
> + * pages that it needs to isolate as migration target during its work.
> + */
> +static inline unsigned long compact_gap(unsigned int order)
> +{
> +	/*
> +	 * Although all the isolations for migration are temporary, compaction
> +	 * may have up to 1 << order pages on its list and then try to split
> +	 * an (order - 1) free page. At that point, a gap of 1 << order might
> +	 * not be enough, so it's safer to require twice that amount.
> +	 */
> +	return 2UL << order;
> +}

I agree with this wrapper function but there is a question.

Could you elaborate more on this code comment? Freescanner could keep
COMPACT_CLUSTER_MAX freepages on the list. It's not associated with
requested order at least for now. Why compact_gap is 2UL << order in
this case?

Thanks.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v6 08/11] mm, compaction: create compact_gap wrapper Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-08-16 08:20 +0200

csiph-web