Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats

From	Joonsoo Kim <iamjoonsoo.kim@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats
Date	2016-08-16 05:00 +0200
Message-ID	<s6CLE-5JI-19@gated-at.bofh.it> (permalink)
References	<s2wbL-5cb-3@gated-at.bofh.it> <s2BuN-mO-23@gated-at.bofh.it> <s2Oil-eE-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 05, 2016 at 09:21:56AM -0500, Christoph Lameter wrote:
> On Fri, 5 Aug 2016, Joonsoo Kim wrote:
> 
> > If above my comments are fixed, all counting would be done with
> > holding a lock. So, atomic definition isn't needed for the SLAB.
> 
> Ditto for slub. struct kmem_cache_node is alrady defined in mm/slab.h.
> Thus it is a common definition already and can be used by both.
> 
> Making nr_slabs and total_objects unsigned long would be great.

In SLUB, nr_slabs is manipulated without holding a lock so atomic
operation should be used.

Anyway, Aruna. Could you handle my comment?

Thank.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-08-16 05:00 +0200
  Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Christoph Lameter <cl@linux.com> - 2016-08-16 18:00 +0200
    Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats aruna.ramakrishna@oracle.com - 2016-08-17 09:20 +0200
      Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo  stats Christoph Lameter <cl@linux.com> - 2016-08-17 16:40 +0200

csiph-web