Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access
Date	2016-08-14 21:40 +0200
Message-ID	<s69qh-3Ty-3@gated-at.bofh.it> (permalink)
References	<s3YyZ-5Ay-7@gated-at.bofh.it> <s3Yz1-5Ay-65@gated-at.bofh.it> <s5ZKh-5XL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hans Verkuil <hverkuil@xs4all.nl> writes:

> On 08/08/2016 09:30 PM, Robert Jarzmik wrote:
>> Add pxa_camera registers access through advanced video debugging.
>> +static int pxac_vidioc_g_chip_info(struct file *file, void *fh,
>> +				   struct v4l2_dbg_chip_info *chip)
>
> You shouldn't need this g_chip_info function, it should be handled automatically
> by the v4l2 core. Just drop it.
Okay, let me try and rerun v4l-compliance to be sure I'm covered, and stage it
afterwards for v4.

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register  access Hans Verkuil <hverkuil@xs4all.nl> - 2016-08-14 11:20 +0200
  Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-14 21:40 +0200

csiph-web