Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

From	Jason Cooper <jason@lakedaemon.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy
Date	2016-08-14 20:20 +0200
Message-ID	<s68aR-35C-15@gated-at.bofh.it> (permalink)
References	(4 earlier) <s3WGR-4qo-5@gated-at.bofh.it> <s48RH-3Wx-29@gated-at.bofh.it> <s4dRo-752-19@gated-at.bofh.it> <s4fTc-bN-27@gated-at.bofh.it> <s4Lq1-3su-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey Ted,

On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote:
> On Tue, Aug 09, 2016 at 02:04:44PM +0000, Jason Cooper wrote:
> > iiuc, Ted, you're saying using the hw_random framework would be
> > disasterous because despite most drivers having a default quality of 0,
> > rngd assumes 1 bit of entropy for every bit read?
> 
> Sorry, what I was trying to say (but failed) was that bypassing the
> hwrng framework and injecting entropy directly the entropy pool was
> disatrous.

Ok, whew. :)

> > Thankfully, most hw_random drivers don't set the quality.  So unless the
> > user sets the default_quality param, it's zero.
> 
> The fact that this is "most" and not "all" does scare me a little.

My recent grep showed that only virtio-rng set it to a non-zero value.

> As far as I'm concerned *all* hw_random drivers should set quality to
> zero, since it should be up to the system administrator.

Agreed.

Gathering conversation about this from a few related threads, I have one
concern.  Apparently there is some confusion in userspace consumers of
/dev/hwrng data as to the quality of it.  Specifically, rngd (spotted by
Stephan Mueller) appears to assume 1bit of entropy per 1 bit read. :-/

So, while moving ath9k-rng to the hwrng framework makes complete sense
internally, it's not so good for existing userspace assumptions.  I'd
think that timeriomem-rng falls in this same category.

In light of this, do you think it's worth the effort (I'm volunteering)
to create a subcategory of hwrng drivers that are 'environemntal' rngs?
They can contribute to the kernel entropy pools, but not to /dev/hwrng.

thx,

Jason.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Theodore Ts'o <tytso@mit.edu> - 2016-08-11 01:50 +0200
  Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-14 20:20 +0200

csiph-web