Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1462122

[PATCH] perf evsel: remove redundant check of field being non-null

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The check if field is non-null in the ternary operator is
redundant since this check is made in the previousl if statement.
Remove this redundant check.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index d9b80ef..f4b1206 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2341,7 +2341,7 @@ u64 perf_evsel__intval(struct perf_evsel *evsel, struct perf_sample *sample,
 	if (!field)
 		return 0;
 
-	return field ? format_field__intval(field, sample, evsel->needs_swap) : 0;
+	return format_field__intval(field, sample, evsel->needs_swap);
 }
 
 bool perf_evsel__fallback(struct perf_evsel *evsel, int err,
-- 
2.8.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] perf evsel: remove redundant check of field being non-null Colin King <colin.king@canonical.com> - 2016-08-14 15:20 +0200

csiph-web