Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1461758

[PATCH 1/3] Input: psmouse: Remove deprecated create_singletheread_workqueue

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] Input: psmouse: Remove deprecated create_singletheread_workqueue
Date Sun, 14 Aug 2016 11:50:02 +0200
Message-ID <s60dk-6bP-11@gated-at.bofh.it> (permalink)
References <s5ZAC-5TR-17@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=p3Yn5RhJCLJ/I/aVVqLCfo+pTuOSd9zblXtTkI7l0Fw=; b=MrzBY2msw3+GmrhcUx/mX8z3L1YO3Ht7Fk2zjWkyLjKP2gfzC1HF5bUGCy3ZsRabNj 3JN8zIZ9svD8zIt1j2syTOxl2hueXd1jNMSEvNgW8EUH/Yj6HKyvJhun4ueWauwuSxNr TWv29V3EIXhKTSohAcxXthKj/2vnLGI+7Sexx8sZIDFKClEHSjlpDlRB36VB+lEHmAkq Gv7/poTDMEs+4LhxP1l0CpAWHyMY1hg+pYKhrYYoyQ8nKy5gd6FKcm/ikTmZXqG1JcAi Ordjyos/yxtRcb/Q0/CNAN0df16nShyo1Na5LOLsd2KC0lQ6dmxaDASB22od4824TS0h Uztg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=p3Yn5RhJCLJ/I/aVVqLCfo+pTuOSd9zblXtTkI7l0Fw=; b=PR2uHT/lXrYJo9shmP6wbkAE0V9w8E/GyAN1XqxbvuBhYEBDN48UMRgJjL1yyfVKLx 5PtFgsLxU4twyQvtSpgVINbT+SH6miQTLgNTTJI9VQrPj9O6MhJzB8LBvtAO4Ald6gYw nf7dE3UWQ4+scvNEVZE/g7AB2Y5GX1r31NdORNd6083XFOyFWRRZWY0G6ghfj8hwe2Wv zs1JvbOI1yUkNPFf7TJdfOeqSgMBC1R2WCLiCXYIsu2b/0n96UI4Kkk4Ix7HdVDTl/+a H5WNHgklIrwF6fPen+tOPbgIbIxwYwm2XDX57yEEbsDdQuRCkJoqV1/6N/RJxbwxXOKi Heew==
X-Gm-Message-State AEkoousyG/Yf8pB7BsYN83pzdrnJ3U3C/tYSE8p7K495Vi3NnJWyJDrKEqvRZ9/KCe+fBg==
X-Received by 10.98.18.221 with SMTP id 90mr42188619pfs.3.1471152190714; Sat, 13 Aug 2016 22:23:10 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc Tejun Heo <tj@kernel.org>, patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 14 Aug 2016 10:53:07 +0530
X-Original-Message-ID <83fc8cbf4f5ef7b5e814353468b9ee9d5dd6d7d2.1471151622.git.bhaktipriya96@gmail.com>
X-Original-References <cover.1471151622.git.bhaktipriya96@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1461758

Show key headers only | View raw


alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.

There are multiple work items on the work queue viz
&priv->dev3_register_work, &priv->recalib_wq, &psmouse->resync_work,
which require execution ordering. Hence, an ordered workqueue has been
used.

The workqueue is not being used on a memory reclaim path.
Hence, WQ_MEM_RECLAIM has not been set.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/input/mouse/psmouse-base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
index 5784e20..fb4b185 100644
--- a/drivers/input/mouse/psmouse-base.c
+++ b/drivers/input/mouse/psmouse-base.c
@@ -1916,7 +1916,7 @@ static int __init psmouse_init(void)
 	synaptics_module_init();
 	hgpk_module_init();

-	kpsmoused_wq = create_singlethread_workqueue("kpsmoused");
+	kpsmoused_wq = alloc_ordered_workqueue("kpsmoused", 0);
 	if (!kpsmoused_wq) {
 		pr_err("failed to create kpsmoused workqueue\n");
 		return -ENOMEM;
--
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] Remove usages of deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-14 11:30 +0200
  [PATCH 2/3] Input: touchscreen: mc13783_ts:  Remove deprecated  create_singletheread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-14 11:30 +0200
    Re: [PATCH 2/3] Input: touchscreen: mc13783_ts:  Remove deprecated  create_singletheread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-16 01:00 +0200
    Re: [PATCH 2/3] Input: touchscreen: mc13783_ts:  Remove deprecated  create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:00 +0200
  [PATCH 1/3] Input: psmouse: Remove deprecated  create_singletheread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-08-14 11:50 +0200
    Re: [PATCH 1/3] Input: psmouse: Remove deprecated  create_singletheread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-16 01:00 +0200
      Re: [PATCH 1/3] Input: psmouse: Remove deprecated  create_singletheread_workqueue Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-23 23:50 +0200

csiph-web