Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461518

Re: [PATCH] Documentation: kprobes: Document jprobes stack copying limitations

Show all headers | View raw

On Fri, 12 Aug 2016 16:24:44 -0400
David Long <dave.long@linaro.org> wrote:

> From: "David A. Long" <dave.long@linaro.org>
> 
> Some architectures (i.e.: sparc64 and arm64) make reasonable partial stack
> duplication for jprobes problematic. Document this.
> 
> Signed-off-by: David A. Long <dave.long@linaro.org>

Looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> ---
>  Documentation/kprobes.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt
> index 1f9b3e2..1f6d45a 100644
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -103,6 +103,16 @@ Note that the probed function's args may be passed on the stack
>  or in registers.  The jprobe will work in either case, so long as the
>  handler's prototype matches that of the probed function.
>  
> +Note that in some architectures (e.g.: arm64 and sparc64) the stack
> +copy is not done, as the actual location of stacked parameters may be
> +outside of a reasonable MAX_STACK_SIZE value and because that location
> +cannot be determined by the jprobes code. In this case the jprobes
> +user must be careful to make certain the calling signature of the
> +function does not cause parameters to be passed on the stack (e.g.:
> +more than eight function arguments, an argument of more than sixteen
> +bytes, or more than 64 bytes of argument data, depending on
> +architecture).
> +
>  1.3 Return Probes
>  
>  1.3.1 How Does a Return Probe Work?
> -- 
> 2.5.0
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Documentation: kprobes: Document jprobes stack copying limitations David Long <dave.long@linaro.org> - 2016-08-12 22:30 +0200
  Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations Masami Hiramatsu <mhiramat@kernel.org> - 2016-08-13 01:50 +0200
  Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations Jonathan Corbet <corbet@lwn.net> - 2016-08-15 16:30 +0200
    Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations David Long <dave.long@linaro.org> - 2016-08-15 16:50 +0200
      Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations Jonathan Corbet <corbet@lwn.net> - 2016-08-15 17:40 +0200
        Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations David Long <dave.long@linaro.org> - 2016-08-15 17:50 +0200
        Re: [PATCH] Documentation: kprobes: Document jprobes stack copying  limitations Catalin Marinas <catalin.marinas@arm.com> - 2016-08-15 17:50 +0200

csiph-web