Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1461420
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals |
| Date | 2016-08-12 21:00 +0200 |
| Message-ID | <s5pQt-5rK-29@gated-at.bofh.it> (permalink) |
| References | <s4U9X-1Pt-3@gated-at.bofh.it> <s4U9X-1Pt-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 11, 2016 at 05:01:53PM +0800, Dongpo Li wrote:
> From: Li Dongpo <lidongpo@hisilicon.com>
>
> Add three reset control signals, "mac_core_rst", "mac_ifc_rst" and
> "phy_rst".
> The following diagram explained how the reset signals work.
>
> SoC
> |-----------------------------------------------------
> | ------ |
> | | cpu | |
> | ------ |
> | | |
> | ------------ AMBA bus |
> | GMAC | |
> | ---------------------- |
> | ------------- mac_core_rst | -------------- | |
> | |clock and |-------------->| mac core | | |
> | |reset | | -------------- | |
> | |generator |---- | | | |
> | ------------- | | ---------------- | |
> | | ---------->| mac interface | | |
> | | mac_ifc_rst | ---------------- | |
> | | | | | |
> | | | ------------------ | |
> | |phy_rst | | RGMII interface | | |
> | | | ------------------ | |
> | | ---------------------- |
> |----------|------------------------------------------|
> | |
> | ----------
> |--------------------- |PHY chip |
> ----------
>
> The "mac_core_rst" represents "mac core reset signal", it resets
> the mac core including packet processing unit, descriptor processing unit,
> tx engine, rx engine, control unit.
> The "mac_ifc_rst" represents "mac interface reset signal", it resets
> the mac interface. The mac interface unit connects mac core and
> data interface like MII/RMII/RGMII. After we set a new value of
> interface mode, we must reset mac interface to reload the new mode value.
> The "phy_rst" represents "phy reset signal", it does a hardware reset
> on the PHY chip. This reset signal is optinal if the PHY can work well
> without the hardware reset.
>
> Add one more clock signal, the existing is MAC core clock,
> and the new one is MAC interface clock.
>
> Signed-off-by: Dongpo Li <lidongpo@hisilicon.com>
> ---
> .../bindings/net/hisilicon-hix5hd2-gmac.txt | 16 ++-
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 140 +++++++++++++++++++--
> 2 files changed, 143 insertions(+), 13 deletions(-)
>
> @@ -807,16 +829,26 @@ static int hix5hd2_net_open(struct net_device *dev)
> struct phy_device *phy;
> int ret;
>
> - ret = clk_prepare_enable(priv->clk);
> + ret = clk_prepare_enable(priv->mac_core_clk);
> + if (ret < 0) {
> + netdev_err(dev, "failed to enable mac core clk %d\n", ret);
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(priv->mac_ifc_clk);
> if (ret < 0) {
> - netdev_err(dev, "failed to enable clk %d\n", ret);
> + clk_disable_unprepare(priv->mac_core_clk);
> + netdev_err(dev, "failed to enable mac ifc clk %d\n", ret);
This change will break with existing DTs. The mac_ifc_clk should be
optional.
Rob
> return ret;
> }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals Dongpo Li <lidongpo@hisilicon.com> - 2016-08-11 11:10 +0200
Re: [PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals Rob Herring <robh@kernel.org> - 2016-08-12 21:00 +0200
Re: [PATCH 2/4] net: hix5hd2_gmac: add reset control and clock signals Dongpo Li <lidongpo@hisilicon.com> - 2016-08-15 09:20 +0200
csiph-web