Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461398

Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections

Show all headers | View raw

On 08/12/2016 01:06 PM, Kees Cook wrote:
> On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang <jszhang@marvell.com> wrote:
>> vdso_data_mapping is never modified, so mark it as const.
>>
>> vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are
>> initialized by vdso_init(), thereafter are read only.
>>
>> The fact that they are read only after init makes them candidates for
>> __ro_after_init declarations.
>>
>> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> 
> Looks great; thanks for keeping __ro_after_init in mind. :)
> 
> Reviewed-by: Kees Cook <keescook@chromium.org>

Looks fine and nothing goes wrong with my vdso tests.  Please send it
through Russell.

Acked-by: Nathan Lynch <nathan_lynch@mentor.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections Jisheng Zhang <jszhang@marvell.com> - 2016-08-12 10:30 +0200
  Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into  proper sections Kees Cook <keescook@chromium.org> - 2016-08-12 20:10 +0200
    Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into  proper sections Nathan Lynch <Nathan_Lynch@mentor.com> - 2016-08-12 20:50 +0200

csiph-web