Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

From	James Bottomley <jejb@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()
Date	2016-08-12 19:50 +0200
Message-ID	<s5oKK-4LA-17@gated-at.bofh.it> (permalink)
References	<ryrSH-2fO-11@gated-at.bofh.it> <s04MF-63R-3@gated-at.bofh.it> <s04MF-63R-5@gated-at.bofh.it> <s04MF-63R-7@gated-at.bofh.it> <s04MF-63R-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-07-28 at 21:23 -0400, Martin K. Petersen wrote:
> > > > > > "Calvin" == Calvin Owens <calvinowens@fb.com> writes:
> 
> > > Any thoughts? Squinting at this more it still seems racy, but a
> > > narrow race is surely better than just blatantly freeing
> > > everything
> > > while the file is still exposed in /sys? Is there a better way
> > > you'd
> > > prefer I accomplish this?
> > > 
> > > (I have boxes that OOPS all the time from monitoring code reading
> > > the
> > > /sys files, with this patch I haven't seen a single one.)
> 
> Calvin> Ping? Thoughts, comments?
> 
> James: This is your puppy...

I thought it would be bigger by now going by the early paw size
indicator ...

Anyway

Reviewed-by: James Bottomley <jejb@linux.vnet.ibm.com>

James

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev() James Bottomley <jejb@linux.vnet.ibm.com> - 2016-08-12 19:50 +0200

csiph-web