Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable
Date	Fri, 12 Aug 2016 16:40:02 +0200
Message-ID	<s5lMS-2Ra-39@gated-at.bofh.it> (permalink)
References	<s4H34-I0-25@gated-at.bofh.it> <s4Iiu-1wh-37@gated-at.bofh.it> <s5ke5-1K2-1@gated-at.bofh.it> <s5laa-2oe-15@gated-at.bofh.it> <s5lDb-2Nj-23@gated-at.bofh.it>
X-X-Sender	jkosina@pobox.suse.cz
User-Agent	Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Eric Dumazet <eric.dumazet@gmail.com>, Jamal Hadi Salim <jhs@mojatatu.com>, Phil Sutter <phil@nwl.cc>, Cong Wang <xiyou.wangcong@gmail.com>, David Miller <davem@davemloft.net>, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
X-Original-Date	Fri, 12 Aug 2016 16:36:01 +0200 (CEST)
X-Original-Message-ID	<alpine.LNX.2.00.1608121634520.22028@cbobk.fhfr.pm>
X-Original-References	<alpine.LNX.2.00.1608101049260.22028@cbobk.fhfr.pm> <alpine.LNX.2.00.1608101054320.22028@cbobk.fhfr.pm> <57ADC6AA.5070506@iogearbox.net> <alpine.LNX.2.00.1608121523020.22028@cbobk.fhfr.pm> <57ADDC8B.9010700@iogearbox.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1461221

Show key headers only | View raw

On Fri, 12 Aug 2016, Daniel Borkmann wrote:

> > I was thinking about something like the patch below (the reasong being 
> > that ->dev would be NULL only in cases of singletonish qdiscs) ... 
> > wouldn't that also fix the issue you're seeing? Have to think it 
> > through a little bit more ..
> 
> Ahh, so this has the same effect as previously observed with the other fix.

Thanks a lot for confirming that this fixes the panic. I still have to 
think a little bit more about this though.

> Perhaps it's just a dumping issue, but to the below clsact, there shouldn't
> be pfifo_fast instances appearing.
> 
> # tc qdisc show dev wlp2s0b1
> qdisc mq 0: root
> qdisc pfifo_fast 0: parent :4 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :3 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :2 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :1 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> # tc qdisc add dev wlp2s0b1 clsact
> # tc qdisc show dev wlp2s0b1
> qdisc mq 0: root
> qdisc pfifo_fast 0: parent :4 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :3 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :2 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :1 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc clsact ffff: parent ffff:fff1
> qdisc pfifo_fast 0: parent :4 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :3 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :2 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
> qdisc pfifo_fast 0: parent :1 bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1

Hmm, no immediate idea where those are coming from, we'll have to figure 
it out. The mq device used here has 4 queues, right?

-- 
Jiri Kosina
SUSE Labs

Thread

Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Daniel Borkmann <daniel@iogearbox.net> - 2016-08-12 15:00 +0200
  Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Jiri Kosina <jikos@kernel.org> - 2016-08-12 16:00 +0200
    Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Daniel Borkmann <daniel@iogearbox.net> - 2016-08-12 16:30 +0200
      Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Jiri Kosina <jikos@kernel.org> - 2016-08-12 16:40 +0200
        Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Daniel Borkmann <daniel@iogearbox.net> - 2016-08-12 16:50 +0200
    Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Cong Wang <xiyou.wangcong@gmail.com> - 2016-08-14 10:30 +0200
      Re: [PATCH 2/2] net: sched: convert qdisc linked list to hashtable Jiri Kosina <jikos@kernel.org> - 2016-08-16 01:30 +0200

csiph-web