Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool

From	Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool
Date	2016-08-12 12:10 +0200
Message-ID	<s5hzA-if-3@gated-at.bofh.it> (permalink)
References	<s2Jsl-5yi-3@gated-at.bofh.it> <s2Jsl-5yi-7@gated-at.bofh.it> <s2Lua-6Rn-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Friday 05 August 2016 04:55 PM, Julia Lawall wrote:
> Use of_property_read_bool to check for the existence of a property.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression e1,e2,x;
> @@
> -	if (of_get_property(e1,e2,NULL))
> -		x = true;
> -	else
> -		x = false;
> +	x = of_property_read_bool(e1,e2);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

merged, thanks.

-Kishon
> 
> ---
> v2: special case for propagating true and false
> 
>  drivers/phy/phy-qcom-ufs.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index 107cb57..18a5b49 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
>  			err = 0;
>  		}
>  		snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name);
> -		if (of_get_property(dev->of_node, prop_name, NULL))
> -			vreg->is_always_on = true;
> -		else
> -			vreg->is_always_on = false;
> +		vreg->is_always_on = of_property_read_bool(dev->of_node,
> +							   prop_name);
>  	}
> 
>  	if (!strcmp(name, "vdda-pll")) {
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool Kishon Vijay Abraham I <kishon@ti.com> - 2016-08-12 12:10 +0200

csiph-web