Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460953
| From | Huaitong Han <huaitong.han@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer |
| Date | 2016-08-12 07:40 +0200 |
| Message-ID | <s5dmh-5Xg-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK, cpu_in_cluster is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu would get a NULL pointer bug: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff8105ac25>] x2apic_cluster_probe+0x35/0x70 Signed-off-by: Huaitong Han <huaitong.han@intel.com> --- arch/x86/kernel/apic/x2apic_cluster.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c index 6368fa6..6acb055 100644 --- a/arch/x86/kernel/apic/x2apic_cluster.c +++ b/arch/x86/kernel/apic/x2apic_cluster.c @@ -190,9 +190,10 @@ static int x2apic_cluster_probe(void) if (!x2apic_mode) return 0; - cpumask_set_cpu(cpu, per_cpu(cpus_in_cluster, cpu)); cpuhp_setup_state(CPUHP_X2APIC_PREPARE, "X2APIC_PREPARE", x2apic_prepare_cpu, x2apic_dead_cpu); + cpumask_set_cpu(cpu, per_cpu(cpus_in_cluster, cpu)); + return 1; } -- 1.8.3.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer Huaitong Han <huaitong.han@intel.com> - 2016-08-12 07:40 +0200
Re: [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer Wanpeng Li <kernellwp@gmail.com> - 2016-08-12 08:00 +0200
Re: [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer "Han, Huaitong" <huaitong.han@intel.com> - 2016-08-12 08:10 +0200
csiph-web