Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1461739

Re: [PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack

Show all headers | View raw

On Fri, Aug 12, 2016 at 7:29 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> There has been a 64-byte gap at the end of the irq stack for at least 12
> years.  It predates git history, and I can't find any good reason for
> it.  Remove it.  What's the worst that could happen?

I can't think of any reason this would matter.

For that matter, do you have any idea why irq_stack_union is a union
or why we insist on sticking it at %gs:0?  Sure, the *canary* needs to
live at a fixed offset (because GCC is daft, sigh), but I don't see
what that has to do with the rest of the IRQ stack.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-12 16:40 +0200
  Re: [PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack Andy Lutomirski <luto@amacapital.net> - 2016-08-14 11:10 +0200
    Re: [PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack Brian Gerst <brgerst@gmail.com> - 2016-08-14 15:00 +0200
      Re: [PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-15 19:10 +0200
    Re: [PATCH v3 45/51] x86: remove 64-byte gap at end of irq stack Josh Poimboeuf <jpoimboe@redhat.com> - 2016-08-15 17:50 +0200

csiph-web