Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2
Date	2016-08-13 13:20 +0200
Message-ID	<s5F8R-8N-5@gated-at.bofh.it> (permalink)
References	<s3YyZ-5Ay-7@gated-at.bofh.it> <s3Yz1-5Ay-67@gated-at.bofh.it> <s5Dqq-7sT-9@gated-at.bofh.it> <s5DA5-7ww-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hans Verkuil <hverkuil@xs4all.nl> writes:

> On 08/13/2016 11:25 AM, Robert Jarzmik wrote:
>> Hi Hans,
>> 
>> Robert Jarzmik <robert.jarzmik@free.fr> writes:
>>> Convert pxa_camera from videobuf to videobuf2.
>> ...zip...
>> 
>>> +static int pxac_vb2_queue_setup(struct vb2_queue *vq,
>>> +				unsigned int *nbufs,
>>> +				unsigned int *num_planes, unsigned int sizes[],
>>> +				void *alloc_ctxs[])
>> 
>> There is an API change here that happened since I wrote this code, ie. void
>> *alloc_ctxs became struct device *alloc_devs.
>> 
>> I made the incremental patch in [1] accrodingly to prepare the v4 iteration, but
>> it triggers new errors in v4l2-compliance -s :
>> Streaming ioctls:
>> 	test read/write: OK (Not Supported)
>> 		fail: v4l2-test-buffers.cpp(293): !(g_flags() & V4L2_BUF_FLAG_DONE)
>> 		fail: v4l2-test-buffers.cpp(703): buf.check(q, last_seq)
>> 		fail: v4l2-test-buffers.cpp(976): captureBufs(node, q, m2m_q, frame_count, false)
>> 	test MMAP: FAIL
>> 		fail: v4l2-test-buffers.cpp(1075): can_stream && ret != EINVAL
>> 	test USERPTR: FAIL
>> 	test DMABUF: Cannot test, specify --expbuf-device
>> Total: 45, Succeeded: 43, Failed: 2, Warnings: 6
>> 
>> I'm a bit puzzled how this change brought this in, so in case you've already
>> encountered this, it could save me investigating more. If nothing obvious
>> appears to you, I'll dig in.
>
> Make sure you have the latest v4l2-compliance code as well. A fix went into vb2
> that corrected a bug relating to the V4L2_BUF_FLAG_DONE, but that required a fix for
> v4l2-compliance as well. I'd say that's what you are seeing here.

Indeed, this is fixed in v4l-utils somewhere between v4l-utils-1.8.1 and master,
and I don't get any error anymore.

Thanks for the info, I've updated accordingly my work tree :
       https://github.com/rjarzmik/linux.git work/v4l2

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2 Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-13 11:30 +0200
  Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2 Hans Verkuil <hverkuil@xs4all.nl> - 2016-08-13 11:40 +0200
    Re: [PATCH v3 05/14] media: platform: pxa_camera: convert to vb2 Robert Jarzmik <robert.jarzmik@free.fr> - 2016-08-13 13:20 +0200

csiph-web