Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460868

Re: [PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2)

Show all headers | View raw

On Mon, 2016-08-08 at 18:08 +0200, Christophe Leroy wrote:
> Commit 0e6e01ff694ee ("CPM/QE: use genalloc to manage CPM/QE muram")
> has changed the way muram is managed.
> genalloc uses kmalloc(), hence requires the SLAB to be up and running.
> 
> On powerpc 8xx, cpm_reset() is called early during startup.
> cpm_reset() then calls cpm_muram_init() before SLAB is available,
> hence the following Oops.
> 
> cpm_reset() cannot be called during initcalls because the CPM is
> needed for console
> 
> This patch splits cpm_muram_init() in two parts. The first part,
> related to mappings, is kept as cpm_muram_init()
> The second part is named cpm_muram_pool_init() and is called
> the first time cpm_muram_alloc() is used

Why do you need to split it, versus calling the full cpm_muram_init() on
demand?

-Scott

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2) Scott Wood <oss@buserror.net> - 2016-08-12 01:40 +0200
  Re: [PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2) Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-12 08:30 +0200

csiph-web