Re: [PATCH v2 1/8] firmware: add new extensible firmware API - sysdata_file_request*()

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/8] firmware: add new extensible firmware API - sysdata_file_request*()
Date	Thu, 11 Aug 2016 23:20:01 +0200
Message-ID	<s55yp-Op-7@gated-at.bofh.it> (permalink)
References	<rKPmx-6T5-3@gated-at.bofh.it> <rKPwe-7h2-1@gated-at.bofh.it>
X-Original-To	"Luis R. Rodriguez" <mcgrof@kernel.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pdlWgpoL7D/NoR4Cc9goqITTHyiO0VChUZkveH1xozU=; b=Rr2EYv49dTqstc3rEYP1HiJW77OBwGCFIK4MG1f1GpSe91fW6Byy9jgFgOlUjiIP4Q G8pY4rTjjOiMJdqNoQSYPP0m44z2AOvNs23fVOmlANA5GE29KyAYbxPijgw90atwcr2C ddHepBLq8PDyo3Fuh7azyt5O3r00gmxnoVOjQ=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pdlWgpoL7D/NoR4Cc9goqITTHyiO0VChUZkveH1xozU=; b=Ld2hQ7z9w8X2T8zBSjFe82y7AjVDj4IeDgZ2TytcSjzc7Vdy1H7gWZbLRAOBCF2aBC +lHk8qJmUBOyxD1svEYMpFQN5ZIwwBZv5zRoWrhlF23knyPQc8f2KKrEqxZwUdFvZUAr Q/jTPjP/Sk6WAvoKeYUfWw8u/D6N/+UDhykNFHckOyzzAQRq7zp/Ef717wHDDrlsW45g zkpeDkq02S3QMeJCq+sj16krgYqrp7qqDL0j/yWqyGWXX2W3Bm36fUkjb7oGwQSEY4Xc MejhQ4FvQaFJ3E4fcdwvxj5nW/POIpn4snG1qtukuJ+oIothmD9cSYxrk4GyEGM8a2QQ 8I4A==
X-Gm-Message-State	AEkoousKLZ+iu1j1f9GvaUo1EeK6zZun2qK8IHHWpP1M1HcdGdEoCGtuh1bRuN+GWuqX3a0FTUyheLWYQLT4sG2T
X-Received	by 10.107.191.132 with SMTP id p126mr14075461iof.189.1470950131640; Thu, 11 Aug 2016 14:15:31 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	Ming Lei <ming.lei@canonical.com>, Andrew Morton <akpm@linux-foundation.org>, mmarek@suse.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, bp@alien8.de, chunkeey@googlemail.com, lkml <linux-kernel@vger.kernel.org>, markivx@codeaurora.org, Stephen Boyd <stephen.boyd@linaro.org>, Mimi Zohar <zohar@linux.vnet.ibm.com>, Mark Brown <broonie@kernel.org>, tiwai@suse.de, johannes@sipsolutions.net, hauke@hauke-m.de, jwboyer@fedoraproject.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Jiri Slaby <jslaby@suse.com>, Linus Torvalds <torvalds@linux-foundation.org>, Andy Lutomirski <luto@amacapital.net>, fengguang.wu@intel.com, Richard Purdie <rpurdie@rpsys.net>, ki@samsung.com, Abhay_Salunke@dell.com, Julia Lawall <Julia.Lawall@lip6.fr>, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr, teg@jklm.no, David Howells <dhowells@redhat.com>, Kees Cook <keescook@chromium.org>, tj@kernel.org, daniel.vetter@ffwll.ch, Jonathan Corbet <corbet@lwn.net>
X-Original-Date	Thu, 11 Aug 2016 14:15:31 -0700
X-Original-Message-ID	<CAOCOHw4CKqm=a0tePipjPraRzsqnK9YF1R+P06F_W3dt4x616g@mail.gmail.com>
X-Original-References	<1466121559-22363-1-git-send-email-mcgrof@kernel.org> <1466121559-22363-2-git-send-email-mcgrof@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1460798

Show key headers only | View raw

On Thu, Jun 16, 2016 at 4:59 PM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> The firmware API has evolved over the years slowly, as it
> grows we extend it by adding new routines or at times we extend
> existing routines with more or less arguments. This doesn't scale
> well, when new arguments are added to existing routines it means
> we need to traverse the kernel with a slew of collateral
> evolutions to adjust old driver users. The firmware API is also
> now being used for things outside of the scope of what typically
> would be considered "firmware", an example here is the p54 driver
> enables users to provide a custom EEPROM through this interface.
> Another example is optional CPU microcode updates. This list is
> actually quite endless...
>

Why can't this done in an incremental fashion, like other frameworks
has done, by transitioning the existing APIs to take a argument
structure?

How are these cases of "misuse" going to go away with the introduction
of another non-firmware-loading interface?

> There are other subsystems which would like to make use of the
> APIs for similar things (not firmware) but have different
> requirements and criteria which they'd like to be met for the
> requested file. If different requirements are needed it would
> again mean adding more arguments and making a slew of collateral
> evolutions, or adding yet-another-new-API-call.
>

Is the main problem here that it's named "firmware" or that there are
potential requirements that are inconsistent with something loading
"firmware"?

[..]
>
>  - Usermode helpers is completely ignored, *always*

What technical benefit does this give us?

As discussed elsewhere, having a mechanism for postponing firmware
loading until the appropriate file systems are mounted would remove my
dependency on the usermode helper. But the direction discussed would
be unrelated to firmware vs sysdata.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/8] firmware: add new extensible firmware API - sysdata_file_request*() Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-11 23:20 +0200
  Re: [PATCH v2 1/8] firmware: add new extensible firmware API -  sysdata_file_request*() "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-12 17:30 +0200

csiph-web