Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460793

Re: [PATCH] genirq: Correctly configure the trigger on chained interrupts

Show all headers | View raw

On Thu, Aug 11, 2016 at 5:55 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:

> Commit 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ")
> moved the trigger configuration call from the irqdomain mapping to
> the interrupt being actually requested.
>
> This patch failed to handle the case where we configure a chained
> interrupt, which doesn't get requested through the usual path.
>
> In order to solve this, let's call __irq_set_trigger just before
> starting the cascade interrupt. Special care must be taken to
> make the flow handler stick, as the .irq_set_type method could
> have reset it (it doesn't know we're dealing with a chained
> interrupt).
>
> Based on an initial patch by Jon Hunter.
>
> Fixes: 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Reported-by: Linus Walleij <linus.walleij@linaro.org>
> Tested-by: John Stultz <john.stultz@linaro.org>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

Tested-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] genirq: Correctly configure the trigger on chained interrupts Marc Zyngier <marc.zyngier@arm.com> - 2016-08-11 18:00 +0200
  Re: [PATCH] genirq: Correctly configure the trigger on chained interrupts Linus Walleij <linus.walleij@linaro.org> - 2016-08-11 23:10 +0200

csiph-web