Re: [PATCH 2/8] [media] v4l2-async: call registered_async after subdev registration

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/8] [media] v4l2-async: call registered_async after subdev registration
Date	2016-08-11 21:30 +0200
Message-ID	<s53PX-85l-7@gated-at.bofh.it> (permalink)
References	<qYU5b-4l7-9@gated-at.bofh.it> <qYU5c-4l7-27@gated-at.bofh.it> <s4WbL-34E-17@gated-at.bofh.it> <s4WbL-34E-23@gated-at.bofh.it> <s50S5-66i-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Javier,

On Thu, Aug 11, 2016 at 12:14:01PM -0400, Javier Martinez Canillas wrote:
> Hello Sakari,
> 
> Thanks a lot for your feedback.
> 
> On 08/11/2016 07:18 AM, Sakari Ailus wrote:
> > On Thu, Aug 11, 2016 at 02:10:43PM +0300, Sakari Ailus wrote:
> 
> [snip]
> 
> >>>  
> >>> +	ret = v4l2_subdev_call(sd, core, registered_async);
> >>> +	if (ret < 0) {
> >>> +		if (notifier->unbind)
> >>> +			notifier->unbind(notifier, sd, asd);
> >>> +		return ret;
> >>> +	}
> >>> +
> >>>  	if (list_empty(&notifier->waiting) && notifier->complete)
> >>>  		return notifier->complete(notifier);
> >>
> >> I noticed this just now but what do you need this and the next patch for?
> >>
> >> We already have a callback for the same purpose: it's
> >> v4l2_subdev_ops.internal_ops.registered(). And there's similar
> >> unregistered() callback as well.
> >>
> 
> Oh, I missed we already had those calls. When adding the connector
> support, I looked at struct v4l2_subdev_core_ops and didn't find a
> callback that fit but didn't notice we already had a .registered()
> in struct struct v4l2_subdev_internal_ops. Sorry about that...

No worries. I hadn't time to review the patches either.

> >> Could you use these callbacks instead?
> 
> Yes, those can be used indeed. I'll post patches using that instead
> and removing the .registered_async callback since as you said isn't
> really needed.

I'd appreciate that! Please cc me when you do so.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/8] [media] v4l2-async: call registered_async after  subdev registration Sakari Ailus <sakari.ailus@iki.fi> - 2016-08-11 13:20 +0200
  Re: [PATCH 2/8] [media] v4l2-async: call registered_async after  subdev registration Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-11 18:20 +0200
    Re: [PATCH 2/8] [media] v4l2-async: call registered_async after  subdev registration Sakari Ailus <sakari.ailus@iki.fi> - 2016-08-11 21:30 +0200

csiph-web