Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1459210
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE |
| Date | 2016-08-10 02:20 +0200 |
| Message-ID | <s4ppv-6cf-5@gated-at.bofh.it> (permalink) |
| References | <s3WQx-4tF-3@gated-at.bofh.it> <s3X0e-4wO-17@gated-at.bofh.it> <s4ne2-4FM-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/09/2016 02:56 PM, Florian Fainelli wrote: > On 08/08/2016 10:49 AM, Laura Abbott wrote: >> arm may need the kernel_force_cache APIs to guarantee data consistency. >> Implement versions of these APIs based on the DMA APIs. >> >> Signed-off-by: Laura Abbott <labbott@redhat.com> >> --- >> arch/arm/include/asm/cacheflush.h | 4 ++ >> arch/arm/mm/dma-mapping.c | 119 -------------------------------------- >> arch/arm/mm/flush.c | 115 ++++++++++++++++++++++++++++++++++++ > > Why is the code moved between dma-mapping.c and flush.c? It was not > obvious while looking at these patches why this is needed. > I wanted to use the cache flushing routines from dma-mapping.c and it seemed better to pull them out vs. trying to put more generic cache flushing code in dma-mapping.c. flush.c seemed like an appropriate place although I forgot about the dependency on CONFIG_MMU. It can certainly remain in dma-mapping.c if deemed appropriate. Thanks, Laura
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFCv2][PATCH 0/5] Cleanup Ion mapping/caching Laura Abbott <labbott@redhat.com> - 2016-08-08 20:00 +0200
[RFCv2][PATCH 5/5] staging: ion: Add support for syncing with DMA_BUF_IOCTL_SYNC Laura Abbott <labbott@redhat.com> - 2016-08-08 20:00 +0200
[RFCv2][PATCH 4/5] staging: android: ion: Convert to the kernel_force_cache APIs Laura Abbott <labbott@redhat.com> - 2016-08-08 20:00 +0200
[RFCv2][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE Laura Abbott <labbott@redhat.com> - 2016-08-08 20:00 +0200
[RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE Laura Abbott <labbott@redhat.com> - 2016-08-08 20:00 +0200
Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE Florian Fainelli <f.fainelli@gmail.com> - 2016-08-10 00:00 +0200
Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE Laura Abbott <labbott@redhat.com> - 2016-08-10 02:20 +0200
Re: [RFCv2][PATCH 2/5] arm: Implement ARCH_HAS_FORCE_CACHE Florian Fainelli <f.fainelli@gmail.com> - 2016-08-10 02:30 +0200
csiph-web