Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459027

Re: [PATCH] of: Delete an unnecessary check before the function call "of_node_put"

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] of: Delete an unnecessary check before the function call "of_node_put"
Date 2016-08-09 19:40 +0200
Message-ID <s4jap-2dp-1@gated-at.bofh.it> (permalink)
References (5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rWKhr-oj-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 19, 2016 at 10:52:12PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 19 Jul 2016 22:42:22 +0200
> 
> The of_node_put() function tests whether its argument is NULL
> and then returns immediately.
> Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/of/base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] of: Delete an unnecessary check before the function call  "of_node_put" Rob Herring <robh@kernel.org> - 2016-08-09 19:40 +0200

csiph-web