Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458961

Re: drivers/spi/spi.c:1160:3-9: preceding lock on line 1153

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 09, 2016 at 06:35:06PM +0200, Julia Lawall wrote:
> On Tue, 9 Aug 2016, Mark Brown wrote:
> > On Tue, Aug 09, 2016 at 06:19:13PM +0200, Julia Lawall wrote:

> > > Looks worth checking.

> > I don't really have any idea what this is trying to tell me, sorry.

> The important lines are the ones with the @.  Line 1153 takes a lock and
> in line 1160 there is a return in error handling code with the lock still
> held.  The semantic patch that reported this should also only give a
> report if there is some patch out of the function that releases the lock.
> Overall, it seems unusual to keep the lock in an error case.

I'm not sure how I'm supposed to identify that from the message to be
honest - I'd expect something that more directly referenced both lines
and ideally said something like "lock held when returning".  But yes, it
does look like an issue thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

drivers/spi/spi.c:1160:3-9: preceding lock on line 1153  Julia Lawall <julia.lawall@lip6.fr> - 2016-08-09 18:20 +0200
  Re: drivers/spi/spi.c:1160:3-9: preceding lock on line 1153 Mark Brown <broonie@kernel.org> - 2016-08-09 18:40 +0200
    Re: drivers/spi/spi.c:1160:3-9: preceding lock on line 1153 Julia Lawall <julia.lawall@lip6.fr> - 2016-08-09 18:40 +0200
      Re: drivers/spi/spi.c:1160:3-9: preceding lock on line 1153 Mark Brown <broonie@kernel.org> - 2016-08-09 18:50 +0200

csiph-web