Re: [PATCH] iommu/exynos: Modify error handling

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/exynos: Modify error handling
Date	2016-08-09 17:30 +0200
Message-ID	<s4h8C-UE-17@gated-at.bofh.it> (permalink)
References	<s1fG2-3cM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 01, 2016 at 11:48:38AM +0530, Amitoj Kaur Chawla wrote:
> of_platform_device_create returns NULL on error so an IS_ERR test is
> incorrect here and a NULL check is required.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
> 
>   e = of_platform_device_create(...);
> if(
> -    IS_ERR(e)
> +    !e
>     )
>     {
>   <+...
>   return
> - PTR_ERR(e)
> + -ENODEV
>   ;
>   ...+>
>   }
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/iommu/exynos-iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch didn't apply cleanly against v4.8-rc1, but I fixed it up and it is
now in my tree, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iommu/exynos: Modify error handling Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-08-01 09:20 +0200
  Re: [PATCH] iommu/exynos: Modify error handling Joerg Roedel <joro@8bytes.org> - 2016-08-09 17:30 +0200

csiph-web