Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458650

[PATCH] rtc: pcf2123: Add missing error code assignment before test

Show all headers | View raw

It is likely that checking the result of 'pcf2123_write_reg' is expected
here.
Also fix a small style issue. The '{' at the beginning of the function
is misplaced.

Fixes: 809b453b76e15 ("rtc: pcf2123: clean up writes to the rtc chip")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/rtc/rtc-pcf2123.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index b4478cc92b55..8895f77726e8 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -182,7 +182,8 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr,
 }
 
 static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
-			     const char *buffer, size_t count) {
+			     const char *buffer, size_t count)
+{
 	struct pcf2123_sysfs_reg *r;
 	unsigned long reg;
 	unsigned long val;
@@ -199,7 +200,7 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
 	if (ret)
 		return ret;
 
-	pcf2123_write_reg(dev, reg, val);
+	ret = pcf2123_write_reg(dev, reg, val);
 	if (ret < 0)
 		return -EIO;
 	return count;
-- 
2.7.4


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: pcf2123: Add missing error code assignment before test Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-09 14:00 +0200
  Re: [PATCH] rtc: pcf2123: Add missing error code assignment before  test Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-09 14:10 +0200
  Re: [PATCH] rtc: pcf2123: Add missing error code assignment before  test Julia Lawall <julia.lawall@lip6.fr> - 2016-08-09 14:20 +0200
    Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code  assignment before test Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-09 14:20 +0200

csiph-web