Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy
Date	2016-08-09 14:00 +0200
Message-ID	<s4dRo-752-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <s3sIN-1Y7-5@gated-at.bofh.it> <s3IaR-3wd-7@gated-at.bofh.it> <s3MxQ-6io-31@gated-at.bofh.it> <s3WGR-4qo-5@gated-at.bofh.it> <s48RH-3Wx-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 09, 2016 at 06:30:03AM +0000, Pan, Miaoqing wrote:
> Agree with Jason's point, also understand Stephan's concern.  The
> date rate can be roughly estimated by 'cat /dev/random |rngtest -c
> 1000', the average speed is 1111.294Kibits/s. I will sent the patch
> to disable ath9k RNG by default.

If the ATH9K is generating some random amount of data, but you don't
know how random, and you're gathering it opportunistically --- for
example, suppose a wireless driver gets the radio's signal strength
through the normal course of its operation, and while there might not
be that much randomness for someone who can observe the exact details
of how the phone is positioned in the room --- but for which the
analyst sitting in Fort Meade won't know whether or not the phone is
on the desk, or in a knapsack under the table, the right interface to
use is:

   void add_device_randomness(const void *buf, unsigned int size);
	
This won't increase the entropy count, but if you have the bit of
potential randomness "for free", you might as well contribute it to
the entropy pool.  If it turns out that the chip was manufactured in
China, and the MSS has backdoored it out the wazoo, it won't do any
harm --- where as using the hwrng framework would be disastrous.

Cheerfs,

						- Ted

Thread

[RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy Stephan Mueller <smueller@chronox.de> - 2016-08-05 17:10 +0200
  Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy Stephan Mueller <smueller@chronox.de> - 2016-08-06 22:10 +0200
    Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-06 22:20 +0200
  Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-06 22:10 +0200
  [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Stephan Mueller <smueller@chronox.de> - 2016-08-07 11:40 +0200
    RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy "Pan, Miaoqing" <miaoqing@qti.qualcomm.com> - 2016-08-08 04:10 +0200
      Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Stephan Mueller <smueller@chronox.de> - 2016-08-08 08:50 +0200
        Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-08 19:40 +0200
          Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-09 00:10 +0200
          RE: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy "Pan, Miaoqing" <miaoqing@qti.qualcomm.com> - 2016-08-09 08:40 +0200
            Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Theodore Ts'o <tytso@mit.edu> - 2016-08-09 14:00 +0200
              Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy Jason Cooper <jason@lakedaemon.net> - 2016-08-09 16:10 +0200

csiph-web