Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458541

Re: [PATCH v12 02/11] genirq/msi: msi_compose wrapper

Show all headers | View raw

On Tue, 2 Aug 2016, Eric Auger wrote:

> Currently the MSI message is composed by directly calling
> irq_chip_compose_msi_msg and erased by setting the memory to zero.
> 
> On some platforms, we will need to complexify this composition to
> properly handle MSI emission through IOMMU. Also we will need to track
> when the MSI message is erased.

I just can't find how you do that. After applying the series the

> +	if (erase)
> +		memset(msg, 0, sizeof(*msg));

branch is still just a memset(). The wrapper is fine for the compose side, but
having the extra argument just to wrap the memset() for no gain is silly.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v12 00/11] KVM PCIe/MSI passthrough on ARM/ARM64: kernel part 2/3: msi changes Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:30 +0200
  [PATCH v12 07/11] irqchip/gic-v2m: Register the MSI global doorbell Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:30 +0200
  [PATCH v12 11/11] genirq/msi: Use the MSI doorbell's IOVA when requested Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:30 +0200
  [PATCH v12 09/11] genirq/msi: Introduce msi_desc flags Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:30 +0200
    Re: [PATCH v12 09/11] genirq/msi: Introduce msi_desc flags Auger Eric <eric.auger@redhat.com> - 2016-08-09 09:00 +0200
  [PATCH v12 10/11] genirq/msi: Map/unmap the MSI doorbells on msi_domain_alloc/free_irqs Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:30 +0200
  [PATCH v12 02/11] genirq/msi: msi_compose wrapper Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:50 +0200
    Re: [PATCH v12 02/11] genirq/msi: msi_compose wrapper Thomas Gleixner <tglx@linutronix.de> - 2016-08-09 11:30 +0200
      Re: [PATCH v12 02/11] genirq/msi: msi_compose wrapper Auger Eric <eric.auger@redhat.com> - 2016-08-10 20:20 +0200
  [PATCH v12 06/11] genirq/msi: msi_doorbell_safe Eric Auger <eric.auger@redhat.com> - 2016-08-02 19:50 +0200
  [PATCH v12 03/11] genirq: Introduce irq_get_msi_doorbell_info Eric Auger <eric.auger@redhat.com> - 2016-08-02 20:30 +0200
  [PATCH v12 05/11] genirq/msi: msi_doorbell_calc_pages Eric Auger <eric.auger@redhat.com> - 2016-08-02 21:20 +0200
  [PATCH v12 04/11] genirq/msi: Allow MSI doorbell (un)registration Eric Auger <eric.auger@redhat.com> - 2016-08-02 22:30 +0200

csiph-web