Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458513

Re: [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style

Show all headers | View raw

On Tue, Aug 09, 2016 at 01:23:20AM -0400, Tejun Heo wrote:
> kernfs path formatting functions always return the length of full path
> but the content of the output buffer is undefined when the length is
> longer than the provided buffer.  Most cgroup path formatting
> functions return the start of the output or NULL on errors including
> overflow.  These inconsistent and rather peculiar behaviors developed
> over time and make these functions unnecessarily difficult to use.
> This patchset updates the formatting functions so that they all behave
> in the style of strlcpy().
> 
> Greg, these changes are used by cgroup tracepoint additions and
> shouldn't affect other users much.  Would it be okay to route these
> through the cgroup tree?
> 
>  0001-kernfs-add-dummy-implementation-of-kernfs_path_from_.patch
>  0002-kernfs-make-kernfs_path-behave-in-the-style-of-strlc.patch
>  0003-kernfs-remove-kernfs_path_len.patch
>  0004-cgroup-make-cgroup_path-and-friends-behave-in-the-st.patch
> 
> The patches are also available in the following git branch.
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-kernfs_path-strlcpy
> 
> diffstat follows.  Thanks.

It's fine with me if you take these yourself:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style Tejun Heo <tj@kernel.org> - 2016-08-09 07:30 +0200
  [PATCH 1/4] kernfs: add dummy implementation of kernfs_path_from_node() Tejun Heo <tj@kernel.org> - 2016-08-09 07:30 +0200
    [PATCH v2 1/4] kernfs: add dummy implementation of  kernfs_path_from_node() Tejun Heo <tj@kernel.org> - 2016-08-09 08:20 +0200
  [PATCH 3/4] kernfs: remove kernfs_path_len() Tejun Heo <tj@kernel.org> - 2016-08-09 07:30 +0200
  [PATCH 4/4] cgroup: make cgroup_path() and friends behave in the style of strlcpy() Tejun Heo <tj@kernel.org> - 2016-08-09 07:30 +0200
    [PATCH v2 4/4] cgroup: make cgroup_path() and friends behave in the  style of strlcpy() Tejun Heo <tj@kernel.org> - 2016-08-09 08:20 +0200
  Re: [PATCHSET] kernfs, cgroup: make kernfs_path*() and  cgroup_path*() behave in strlcpy() style Greg KH <gregkh@linuxfoundation.org> - 2016-08-09 10:40 +0200
    Re: [PATCHSET] kernfs, cgroup: make kernfs_path*() and  cgroup_path*() behave in strlcpy() style Tejun Heo <tj@kernel.org> - 2016-08-10 23:30 +0200

csiph-web