Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.
Date	2016-08-11 15:50 +0200
Message-ID	<s4YwW-4uy-5@gated-at.bofh.it> (permalink)
References	<s4V61-2qB-21@gated-at.bofh.it> <s4Wv8-3dk-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote :
> From: Jan Östlund <jao@hms.se>
> 
> The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same
> value. This is no functional change.
> 
> Signed-off-by: Daniel Romell <daro@hms.se>

Sorry, I saw it only before trying apply but both patches also need Jan's SoB.

> ---
>  drivers/rtc/rtc-bq32k.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
> index 0299988..5a0c137 100644
> --- a/drivers/rtc/rtc-bq32k.c
> +++ b/drivers/rtc/rtc-bq32k.c
> @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm)
>  		return error;
>  
>  	tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK);
> -	tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK);
> +	tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK);
>  	tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK);
>  	tm->tm_mday = bcd2bin(regs.date);
>  	tm->tm_wday = bcd2bin(regs.day) - 1;
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH 0/2] bq32000 fixes Daniel Romell <danielromell@gmail.com> - 2016-08-11 12:10 +0200
  [PATCH 2/2] rtc: bq32k: Fix handling of oscillator failure flag Daniel Romell <danielromell@gmail.com> - 2016-08-11 12:10 +0200
    Re: [PATCH 2/2] rtc: bq32k: Fix handling of oscillator failure flag Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-11 12:20 +0200
  [PATCH v2 0/2] bq32000 fixes Daniel Romell <danielromell@gmail.com> - 2016-08-11 13:40 +0200
    [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. Daniel Romell <danielromell@gmail.com> - 2016-08-11 13:40 +0200
      Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes'  register. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-11 15:50 +0200
        Re: [rtc-linux] Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name  for 'minutes' register. Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-08-11 23:20 +0200
      RE: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes'  register. Jan Östlund <jao@hms.se> - 2016-08-15 09:50 +0200

csiph-web