Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460443

Re: [PATCH] byteswap: don't use __builtin_bswap*() with sparse

Show all headers | View raw

On Thursday, August 11, 2016 1:15:02 PM CEST Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Although sparse declares __builtin_bswap*(), it can't actually
> do constant folding inside them (yet). As such, things like
> 
>   switch (protocol) {
>   case htons(ETH_P_IP):
>           break;
>   }
> 
> which we do all over the place cause sparse to warn that it
> expects a constant instead of a function call.
> 
> Disable __HAVE_BUILTIN_BSWAP*__ if __CHECKER__ is defined to
> avoid this.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7322dd755e7d ("byteswap: try to avoid __builtin_constant_p gcc bug")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Looks good, thanks for addressing this!

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] byteswap: don't use __builtin_bswap*() with sparse Johannes Berg <johannes@sipsolutions.net> - 2016-08-11 13:20 +0200
  Re: [PATCH] byteswap: don't use __builtin_bswap*() with sparse Arnd Bergmann <arnd@arndb.de> - 2016-08-11 14:00 +0200

csiph-web