Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460350

Re: [PATCH] drm/omap: remove unneeded conversions to bool

From Tomi Valkeinen <tomi.valkeinen@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/omap: remove unneeded conversions to bool
Date 2016-08-11 12:10 +0200
Message-ID <s4V61-2qB-1@gated-at.bofh.it> (permalink)
References <rQ7C9-7Jf-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On 01/07/16 17:27, Andrew F. Davis wrote:
> Found with scripts/coccinelle/misc/boolconv.cocci.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dispc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index f83608b..495094b 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -1655,7 +1655,7 @@ static void dispc_ovl_set_scaling_uv(enum omap_plane plane,
>  {
>  	int scale_x = out_width != orig_width;
>  	int scale_y = out_height != orig_height;
> -	bool chroma_upscale = plane != OMAP_DSS_WB ? true : false;
> +	bool chroma_upscale = plane != OMAP_DSS_WB;
>  
>  	if (!dss_has_feature(FEAT_HANDLE_UV_SEPARATE))
>  		return;
> @@ -3086,9 +3086,9 @@ static bool _dispc_mgr_pclk_ok(enum omap_channel channel,
>  		unsigned long pclk)
>  {
>  	if (dss_mgr_is_lcd(channel))
> -		return pclk <= dispc.feat->max_lcd_pclk ? true : false;
> +		return pclk <= dispc.feat->max_lcd_pclk;
>  	else
> -		return pclk <= dispc.feat->max_tv_pclk ? true : false;
> +		return pclk <= dispc.feat->max_tv_pclk;
>  }
>  
>  bool dispc_mgr_timings_ok(enum omap_channel channel,
> 

Thanks, queued for v4.9.

 Tomi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] drm/omap: remove unneeded conversions to bool Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-08-11 12:10 +0200

csiph-web