Re: [PATCH v2 1/4] gpio: Add AXP209 GPIO driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/4] gpio: Add AXP209 GPIO driver
Date	2016-08-11 10:30 +0200
Message-ID	<s4Txg-1kY-7@gated-at.bofh.it> (permalink)
References	<rX0vU-2uN-7@gated-at.bofh.it> <rX0vU-2uN-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 20, 2016 at 4:11 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:

> The AXP209 PMIC has a bunch of GPIOs accessible, that are usually used to
> control LEDs or backlight.
>
> Add a driver for them
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Rob Herring <robh@kernel.org>

Patch applied, it's clean and simple. I would suggest the
following immediate improvement (send separate patch):

Add a .get_direction() callback, I have started to push this
for new driver as it gives better userspace experience
and overall better control of stuff.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/4] gpio: Add AXP209 GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2016-08-11 10:30 +0200

csiph-web