Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460265

Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller driver

Show all headers | View raw

On 08/11/2016 09:14 AM, Andreas Werner wrote:
> On Wed, Aug 10, 2016 at 10:28:45PM +0200, Oliver Hartkopp wrote:

>> Just check 'git grep IFF_ECHO'. Even grcan.c and janz-ican3.c have IFF_ECHO
>> set - but implement it in a different way without using the provided
>> machanism from dev.c .
>>
>
> Ok I am with you.

Great :-)

>> A local loopback inside the CAN controller which is generated after
>> successful transmit is an excellent implementation with excellent
>> timestamps. The only problem for you is to detect the looped CAN frames and
>> match them to the skb pointer of the outgoing frame to 'receive' the correct
>> echo skb.
>>
>
> At the moment, i think there is no way to detect those looped frames.
> I will talk to our IC designer and discuss this issue with him. Maybe we
> have the possibility to get a local loopback inside the CAN controller.
> This seems to be the best way to do it.

When you still have the possibility to change the IP core I would 
suggest to create some kind of 16/32 bit value which you can pass to the 
CAN controller along with the CAN frame to be sent.

And when this frame comes back due to the loopback you can use this 
non-zero 16/32 bit value to match into a list of tx skb pointers for 
IFF_ECHO.

E.g. when this 16/32 bit value is zero this CAN frame obviously was 
received from another CAN node.

Just an idea.

Regards,
Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-07-26 11:20 +0200
  Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Benjamin Poirier <benjamin.poirier@gmail.com> - 2016-08-08 06:00 +0200
    Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-08 09:40 +0200
      Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Benjamin Poirier <benjamin.poirier@gmail.com> - 2016-08-09 05:30 +0200
        Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-09 08:20 +0200
  Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Wolfgang Grandegger <wg@grandegger.com> - 2016-08-08 11:40 +0200
    Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-08 13:50 +0200
      Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Wolfgang Grandegger <wg@grandegger.com> - 2016-08-08 14:30 +0200
        Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> - 2016-08-08 15:30 +0200
          Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-08 16:20 +0200
        Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-08 16:10 +0200
          Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Wolfgang Grandegger <wg@grandegger.com> - 2016-08-08 16:40 +0200
            Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-09 08:20 +0200
              Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Wolfgang Grandegger <wg@grandegger.com> - 2016-08-09 14:00 +0200
              Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Oliver Hartkopp <socketcan@hartkopp.net> - 2016-08-10 22:30 +0200
                Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-11 09:20 +0200
                Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Oliver Hartkopp <socketcan@hartkopp.net> - 2016-08-11 10:50 +0200
                Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Andreas Werner <andreas.werner@men.de> - 2016-08-11 11:00 +0200
                Re: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Oliver Hartkopp <socketcan@hartkopp.net> - 2016-08-11 13:50 +0200
  RE: [PATCH RESEND] net: can: Introduce MEN 16Z192-00 CAN controller  driver Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> - 2016-08-09 11:40 +0200

csiph-web