Re: [PATCH] watchdog: core: Fix devres_alloc() allocation size

From	Neil Armstrong <narmstrong@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] watchdog: core: Fix devres_alloc() allocation size
Date	2016-08-11 10:40 +0200
Message-ID	<s4TGW-1oz-17@gated-at.bofh.it> (permalink)
References	<s4KaB-2JP-3@gated-at.bofh.it>
Organization	Baylibre

Show all headers | View raw

On 08/10/2016 07:34 AM, Guenter Roeck wrote:
> Coverity reports:
> 
> Passing argument 152UL /* sizeof (*wdd) */ to function __devres_alloc_node
> and then casting the return value to struct watchdog_device ** is
> suspicious.
> 
> Allocation size needs to be sizeof(*rcwdd), not sizeof(*wdd).
> 
> Fixes: 83fbae5a148c ("watchdog: Add a device managed API for ...")
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/watchdog/watchdog_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
> index 6abb83cd7681..74265b2f806c 100644
> --- a/drivers/watchdog/watchdog_core.c
> +++ b/drivers/watchdog/watchdog_core.c
> @@ -349,7 +349,7 @@ int devm_watchdog_register_device(struct device *dev,
>  	struct watchdog_device **rcwdd;
>  	int ret;
>  
> -	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*wdd),
> +	rcwdd = devres_alloc(devm_watchdog_unregister_device, sizeof(*rcwdd),
>  			     GFP_KERNEL);
>  	if (!rcwdd)
>  		return -ENOMEM;
> 

My bad...

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] watchdog: core: Fix devres_alloc() allocation size Guenter Roeck <linux@roeck-us.net> - 2016-08-11 00:30 +0200
  Re: [PATCH] watchdog: core: Fix devres_alloc() allocation size Neil Armstrong <narmstrong@baylibre.com> - 2016-08-11 10:40 +0200

csiph-web