Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459918

[PATCH 5/8] hisi_sas: add v2 hw slot complete internal abort support

From John Garry <john.garry@huawei.com>
Newsgroups linux.kernel
Subject [PATCH 5/8] hisi_sas: add v2 hw slot complete internal abort support
Date 2016-08-10 23:00 +0200
Message-ID <s4ILv-1Hq-11@gated-at.bofh.it> (permalink)
References <s4GgF-79-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Add code in slot_complete_v2_hw() to deal with the
slots which have completed due to internal abort.

The status codes have the following meaning:
- STAT_IO_ABORTED: the IO has been aborted due to
internal abort, whether by device or individual
abort command
- STAT_IO_COMPLETE: internal abort command has
completed successfully for device or individual
abort command
- STAT_IO_NO_DEVICE: internal abort command has
completed for device but cannot find any IO
- STAT_IO_NOT_VALID: internal abort command has
completed for single command but could not
find the command

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index fec1675..bf9b693 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -227,6 +227,13 @@
 #define CMPLT_HDR_RSPNS_XFRD_MSK	(0x1 << CMPLT_HDR_RSPNS_XFRD_OFF)
 #define CMPLT_HDR_ERX_OFF		12
 #define CMPLT_HDR_ERX_MSK		(0x1 << CMPLT_HDR_ERX_OFF)
+#define CMPLT_HDR_ABORT_STAT_OFF	13
+#define CMPLT_HDR_ABORT_STAT_MSK	(0x7 << CMPLT_HDR_ABORT_STAT_OFF)
+/* abort_stat */
+#define STAT_IO_NOT_VALID		0x1
+#define STAT_IO_NO_DEVICE		0x2
+#define STAT_IO_COMPLETE		0x3
+#define STAT_IO_ABORTED			0x4
 /* dw1 */
 #define CMPLT_HDR_IPTT_OFF		0
 #define CMPLT_HDR_IPTT_MSK		(0xffff << CMPLT_HDR_IPTT_OFF)
@@ -1569,6 +1576,30 @@ slot_complete_v2_hw(struct hisi_hba *hisi_hba, struct hisi_sas_slot *slot,
 		goto out;
 	}
 
+	/* Use SAS+TMF status codes */
+	switch ((complete_hdr->dw0 & CMPLT_HDR_ABORT_STAT_MSK)
+			>> CMPLT_HDR_ABORT_STAT_OFF) {
+	case STAT_IO_ABORTED:
+		/* this io has been aborted by abort command */
+		ts->stat = SAS_ABORTED_TASK;
+		goto out;
+	case STAT_IO_COMPLETE:
+		/* internal abort command complete */
+		ts->stat = TMF_RESP_FUNC_COMPLETE;
+		goto out;
+	case STAT_IO_NO_DEVICE:
+		ts->stat = TMF_RESP_FUNC_COMPLETE;
+		goto out;
+	case STAT_IO_NOT_VALID:
+		/* abort single io, controller don't find
+		 * the io need to abort
+		 */
+		ts->stat = TMF_RESP_FUNC_FAILED;
+		goto out;
+	default:
+		break;
+	}
+
 	if ((complete_hdr->dw0 & CMPLT_HDR_ERX_MSK) &&
 		(!(complete_hdr->dw0 & CMPLT_HDR_RSPNS_XFRD_MSK))) {
 
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 0/8] hisi_sas internal abort support John Garry <john.garry@huawei.com> - 2016-08-10 20:20 +0200
  [PATCH 4/8] hisi_sas: add prep_abort_v2_hw() John Garry <john.garry@huawei.com> - 2016-08-10 21:30 +0200
  [PATCH 2/8] hisi_sas: for internal abort in hisi_sas_dev_gone() John Garry <john.garry@huawei.com> - 2016-08-10 21:30 +0200
  [PATCH 3/8] hisi_sas: add internal abort to hisi_sas_abort_task() John Garry <john.garry@huawei.com> - 2016-08-10 22:50 +0200
  [PATCH 7/8] hisi_sas: add TMF success check John Garry <john.garry@huawei.com> - 2016-08-10 22:50 +0200
  [PATCH 1/8] hisi_sas: add internal abort core code John Garry <john.garry@huawei.com> - 2016-08-10 23:00 +0200
    Re: [PATCH 1/8] hisi_sas: add internal abort core code zhangfei <zhangfei.gao@linaro.org> - 2016-08-21 02:50 +0200
      Re: [PATCH 1/8] hisi_sas: add internal abort core code John Garry <john.garry@huawei.com> - 2016-08-22 10:00 +0200
  [PATCH 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry <john.garry@huawei.com> - 2016-08-10 23:00 +0200

csiph-web