Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1459890
| From | John Stultz <john.stultz@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self |
| Date | 2016-08-10 22:50 +0200 |
| Message-ID | <s4IBQ-1DK-37@gated-at.bofh.it> (permalink) |
| References | <s4p69-5QA-9@gated-at.bofh.it> <s4GA2-f8-13@gated-at.bofh.it> <s4H35-I0-53@gated-at.bofh.it> <s4HZ8-1pa-55@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 10, 2016 at 1:01 PM, Arjan van de Ven <arjan@linux.intel.com> wrote: > On 8/10/2016 12:03 PM, John Stultz wrote: > >> I wasn't entierly sure. I didn't think PR_SET_TIMERSLACK has a >> security hook, but looking again I now see the top-level >> security_task_prctl() check, so maybe not skipping it in this case >> would be good? > > > the easy fix would be to add back the ptrace check.. just either ptrace-able > OR CAP_SYS_NICE ;) Well, I worry that just adds more complexity to trying to understand it. p==current OR CAP_SYS_NICE makes the most sense to me. > then you can prove you only added new stuff as well, and have all the LSM > from before The LSM bits (and how consistent or inconsistent they can be) is really the part that I have the most concern about, and I'm not sure what the best approach would be. thanks -john
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz <john.stultz@linaro.org> - 2016-08-10 02:00 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self Kees Cook <keescook@chromium.org> - 2016-08-10 20:40 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz <john.stultz@linaro.org> - 2016-08-10 21:10 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz <john.stultz@linaro.org> - 2016-08-10 21:20 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self Arjan van de Ven <arjan@linux.intel.com> - 2016-08-10 22:10 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz <john.stultz@linaro.org> - 2016-08-10 22:50 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self Kees Cook <keescook@chromium.org> - 2016-08-10 23:10 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self John Stultz <john.stultz@linaro.org> - 2016-08-10 23:20 +0200
Re: [PATCH] proc: Fix timerslack_ns CAP_SYS_NICE check when adjusting self Kees Cook <keescook@chromium.org> - 2016-08-10 23:30 +0200
csiph-web