Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459695

Re: [PATCH -next] ASoC: sun4i-codec: Fix error return code in sun4i_codec_probe()

Show all headers | View raw

On Wed, Aug 10, 2016 at 9:42 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> Fix to return error code -ENOMEM instead of 0 when create card
> failed, as done elsewhere in this function.
>
> Fixes: 45fb6b6f2aa3 ("ASoC: sunxi: add support for the on-chip
> codec on early Allwinner SoCs")
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
>  sound/soc/sunxi/sun4i-codec.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
> index 0e19c50..e741659 100644
> --- a/sound/soc/sunxi/sun4i-codec.c
> +++ b/sound/soc/sunxi/sun4i-codec.c
> @@ -846,6 +846,7 @@ static int sun4i_codec_probe(struct platform_device *pdev)
>         card = sun4i_codec_create_card(&pdev->dev);
>         if (!card) {
>                 dev_err(&pdev->dev, "Failed to create our card\n");
> +               ret = -ENOMEM;
>                 goto err_unregister_codec;
>         }
>

This works, though it might be better to fix the create_card function and
any custom functions called in there to pass back a proper error value.

Regards
ChenYu

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH -next] ASoC: sun4i-codec: Fix error return code in sun4i_codec_probe() Chen-Yu Tsai <wens@csie.org> - 2016-08-10 21:40 +0200
  Re: [PATCH -next] ASoC: sun4i-codec: Fix error return code in  sun4i_codec_probe() Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-11 16:20 +0200
    Re: [PATCH -next] ASoC: sun4i-codec: Fix error return code in  sun4i_codec_probe() Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-08-22 08:40 +0200

csiph-web