Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459753

Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2

From Christophe Leroy <christophe.leroy@c-s.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2
Date 2016-08-10 22:00 +0200
Message-ID <s4HPt-16w-39@gated-at.bofh.it> (permalink)
References <s2LXc-72j-11@gated-at.bofh.it> <s4HPt-16w-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



Le 10/08/2016 à 10:56, Gabriel Paubert a écrit :
> On Fri, Aug 05, 2016 at 01:28:02PM +0200, Christophe Leroy wrote:
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>>  arch/powerpc/kernel/misc_32.S | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
>> index e025230..e18055c 100644
>> --- a/arch/powerpc/kernel/misc_32.S
>> +++ b/arch/powerpc/kernel/misc_32.S
>> @@ -578,9 +578,8 @@ _GLOBAL(__bswapdi2)
>>  	rlwimi  r9,r4,24,0,7
>>  	rlwimi  r10,r3,24,0,7
>>  	rlwimi  r9,r4,24,16,23
>> -	rlwimi  r10,r3,24,16,23
>> +	rlwimi  r4,r3,24,16,23
>>  	mr      r3,r9
>> -	mr      r4,r10
>>  	blr
>>
>
> Hmmm, are you sure that it works? rlwimi is a bit special since the
> first operand is both an input and an output of the instruction.
>
>

Oops, you are right ...

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] powerpc/32: Remove one insn in __bswapdi2 Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-05 14:00 +0200
  Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Christophe Leroy <christophe.leroy@c-s.fr> - 2016-08-10 22:00 +0200
    Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Gabriel Paubert <paubert@iram.es> - 2016-08-11 23:40 +0200
      Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Segher Boessenkool <segher@kernel.crashing.org> - 2016-08-12 00:20 +0200
        Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Gabriel Paubert <paubert@iram.es> - 2016-08-13 01:00 +0200
  Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Gabriel Paubert <paubert@iram.es> - 2016-08-11 04:10 +0200

csiph-web