Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459714

Re: [PATCH v2] rmap: Fix compound check logic in page_remove_file_rmap

Show all headers | View raw

On Wed, Aug 10, 2016 at 03:10:17PM +0100, Steve Capper wrote:
> In page_remove_file_rmap(.) we have the following check:
>   VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page);
> 
> This is meant to check for either HugeTLB pages or THP when a compound
> page is passed in.
> 
> Unfortunately, if one disables CONFIG_TRANSPARENT_HUGEPAGE, then
> PageTransHuge(.) will always return false, provoking BUGs when one runs
> the libhugetlbfs test suite.
> 
> This patch replaces PageTransHuge(), with PageHead() which will work for
> both HugeTLB and THP.
> 
> Fixes: dd78fedde4b9 ("rmap: support file thp")
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Steve Capper <steve.capper@arm.com>

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

-- 
 Kirill A. Shutemov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] rmap: Fix compound check logic in page_remove_file_rmap Steve Capper <steve.capper@arm.com> - 2016-08-10 21:40 +0200
  Re: [PATCH v2] rmap: Fix compound check logic in  page_remove_file_rmap "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-08-10 21:50 +0200

csiph-web