Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459439

Re: [PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when adding adapter fails

Show all headers | View raw

On Tue, Aug 9, 2016 at 7:30 AM, Wolfram Sang
<wsa-dev@sang-engineering.com> wrote:
> The core will do this for us now.
>
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>

Applied patches 1, 5.

Thanks,

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_i2c.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index 9590bcd321c09a..021aa005623f80 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -938,10 +938,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>                          "Radeon i2c hw bus %s", name);
>                 i2c->adapter.algo = &radeon_i2c_algo;
>                 ret = i2c_add_adapter(&i2c->adapter);
> -               if (ret) {
> -                       DRM_ERROR("Failed to register hw i2c %s\n", name);
> +               if (ret)
>                         goto out_free;
> -               }
>         } else if (rec->hw_capable &&
>                    radeon_hw_i2c &&
>                    ASIC_IS_DCE3(rdev)) {
> @@ -950,10 +948,8 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>                          "Radeon i2c hw bus %s", name);
>                 i2c->adapter.algo = &radeon_atom_i2c_algo;
>                 ret = i2c_add_adapter(&i2c->adapter);
> -               if (ret) {
> -                       DRM_ERROR("Failed to register hw i2c %s\n", name);
> +               if (ret)
>                         goto out_free;
> -               }
>         } else {
>                 /* set the radeon bit adapter */
>                 snprintf(i2c->adapter.name, sizeof(i2c->adapter.name),
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when adding adapter fails Wolfram Sang <wsa-dev@sang-engineering.com> - 2016-08-09 13:40 +0200
  Re: [PATCH 4/5] gpu: drm: radeon: radeon_i2c: don't print error when  adding adapter fails Alex Deucher <alexdeucher@gmail.com> - 2016-08-10 20:30 +0200

csiph-web