[PATCH 6/8] hisi_sas: fail tmf task prep when port detached

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH 6/8] hisi_sas: fail tmf task prep when port detached
Date	2016-08-10 20:20 +0200
Message-ID	<s4GgH-79-79@gated-at.bofh.it> (permalink)
References	<s4GgF-79-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When the port is detached we cannot execute a TMF,
as there can be no device attached to the port.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 6c82e07..af92b137 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
 		return rc;
 	}
 	port = device->port->lldd_port;
-	if (port && !port->port_attached && !tmf) {
+	if (port && !port->port_attached) {
 		if (sas_protocol_ata(task->task_proto)) {
 			struct task_status_struct *ts = &task->task_status;
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 6/8] hisi_sas: fail tmf task prep when port detached John Garry <john.garry@huawei.com> - 2016-08-10 20:20 +0200

csiph-web