Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459348

Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when adding adapter fails

Show all headers | View raw

yes, you right. If we remove this message there is no big problem. But
if we do not remove this it's also ok, right ? What the big deal to
remove this type of messages (i'm just interested) ?


For me it's ok to remove:
Acked-by: Abylay Ospan <aospan@netup.ru>


2016-08-09 10:58 GMT-04:00 Wolfram Sang <wsa@the-dreams.de>:
>
>> Sometimes it better to show more message - especially in error conditions :)
>
> Sure, if they contain additional information.
>
>> btw, do you make sanity check for "duplicate" log messages ?
>
> I checked all error messages if they contain additional information.
>
>>             ret = i2c_add_adapter(&i2c->adap);
>>     -       if (ret) {
>>     -               dev_err(&ndev->pci_dev->dev,
>>     -                       "%s(): failed to add I2C adapter\n", __func__);
>>     +       if (ret)
>>                     return ret;
>>     -       }
>
> IMHO, this one doesn't. __func__ is not helpful to users. And the error
> messages in the core will make sure that a developer knows where to
> start looking.
>



-- 
Abylay Ospan,
NetUP Inc.
http://www.netup.tv

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] media: pci: netup_unidvb: don't print error when adding adapter fails Wolfram Sang <wsa-dev@sang-engineering.com> - 2016-08-09 13:40 +0200
  Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when  adding adapter fails Wolfram Sang <wsa@the-dreams.de> - 2016-08-09 17:00 +0200
    Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when  adding adapter fails Abylay Ospan <aospan@netup.ru> - 2016-08-10 20:20 +0200
      Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when  adding adapter fails Abylay Ospan <aospan@netup.ru> - 2016-08-10 20:50 +0200
      Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when  adding adapter fails Wolfram Sang <wsa@the-dreams.de> - 2016-08-10 23:30 +0200

csiph-web