Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()

From	Ross Zwisler <ross.zwisler@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot()
Date	2016-08-10 20:40 +0200
Message-ID	<s4GA4-f8-119@gated-at.bofh.it> (permalink)
References	<s3XWh-55N-19@gated-at.bofh.it> <s3Ypk-5wn-33@gated-at.bofh.it> <s4h8C-UE-21@gated-at.bofh.it> <s4GA4-f8-121@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 10, 2016 at 09:29:23AM +0300, Konstantin Khlebnikov wrote:
> On Tue, Aug 9, 2016 at 6:27 PM, Ross Zwisler
> <ross.zwisler@linux.intel.com> wrote:
> > On Mon, Aug 08, 2016 at 10:21:39PM +0300, Konstantin Khlebnikov wrote:
> > <>
> >> NAK. This is fast path and it's already bloated.
> >> I want to revert most changes here and rework "multiorder" entries.
> >>
> >> Here you can find almost ready patchset for that
> >> https://github.com/koct9i/linux/commits/radix-tree
> >
> > Okay...are you okay with the second 2 patches in the series?  They stand
> > alone, and I believe are both good to have.
> 
> They looks good.

Cool, can I interpret that as an Acked-by for my v2? :)

> If you're worried about complicated paths - I'll add comment for
> *_next_slot() about that.

Yea, if we can document the exact ways in which we're protected from not
dereferencing a NULL 'slot', that would be great.  I think it essentially
boils down to:

1) For tagged iteration, if 'slot' is NULL then iter->tags must be cleared
2) For non-tagged iteration, it 'slot' is NULL then
   radix_tree_chunk_size(iter) must return 1 or less.

Thread

[PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-08 21:00 +0200
  Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot() Konstantin Khlebnikov <koct9i@gmail.com> - 2016-08-08 21:30 +0200
    Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in  radix_tree_next_slot() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-09 17:30 +0200
      Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in  radix_tree_next_slot() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-08-10 20:40 +0200
      Re: [PATCH 1/3] radix-tree: 'slot' can be NULL in radix_tree_next_slot() Konstantin Khlebnikov <koct9i@gmail.com> - 2016-08-10 21:30 +0200

csiph-web