Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459452

Re: [PATCH] max17042_battery: fix model download bug.

Show all headers | View raw

On 08/09/2016 08:54 PM, Sebastian Reichel wrote:
> Hi,
> 
> [adding some people to CC]
> 
> On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
>> The device's model download function returns the model data as
>> an array of u32s, which is later compared to the reference
>> model data. However, since the latter is an array of u16s,
>> the comparison does not happen correctly, and model verification
>> fails. This in turn breaks the POR initialization sequence.
> 
> Patch looks ok, except for missing Fixes. I guess it should be
> "Fixes: 39e7213edc4f3". I will wait with queuing it for a few
> days giving Samsung people a chance to reply.

Looks correct.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Also:
Cc: <stable@vger.kernel.org>

And how about:
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
https://www.marc.info/?l=linux-pm&m=143954612610000&w=4

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] max17042_battery: fix model download bug. Sven Van Asbroeck <thesven73@gmail.com> - 2016-08-03 16:10 +0200
  Re: [PATCH] max17042_battery: fix model download bug. Sebastian Reichel <sre@kernel.org> - 2016-08-09 21:00 +0200
    Re: [PATCH] max17042_battery: fix model download bug. Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-10 20:40 +0200

csiph-web