Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1

From	york sun <york.sun@nxp.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1
Date	2016-08-09 12:40 +0200
Message-ID	<s49b3-43i-5@gated-at.bofh.it> (permalink)
References	(2 earlier) <s3N0S-6HU-27@gated-at.bofh.it> <s3V86-3gZ-35@gated-at.bofh.it> <s463v-240-1@gated-at.bofh.it> <s47sC-36N-15@gated-at.bofh.it> <s47sC-36N-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/08/2016 10:01 PM, Borislav Petkov wrote:
> On Tue, Aug 09, 2016 at 04:31:19AM +0000, york sun wrote:
>> Yes, for most SoCs RFXE remains cleared. Uncorrectable errors are
>> handled by EDAC.
>
> And how is mpc85_xxx EDAC handling them?
>
> mpc85xx_mc_check() only reports them.

Correct. It can only report this kind of error. It is not correctable. 
Nothing more can be done.

>
> And now to get to my original question: is it *enough* to report
> uncorrectable errors on those platforms or do they need more
> sophisticated error handling in order to disable data corruption?
>

It is uncorrectable. DDR controller can only report the error. I don't 
believe EDAC driver can do more. For the same reason I said we can leave 
RXFE as is, even for e500v1 case (with RIO or PCI is enabled). Nothing 
can be done with uncorrectable error.

York

Thread

Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 Borislav Petkov <bp@alien8.de> - 2016-08-08 09:20 +0200
  Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 york sun <york.sun@nxp.com> - 2016-08-08 18:00 +0200
    Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 Borislav Petkov <bp@alien8.de> - 2016-08-09 05:40 +0200
      Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 Borislav Petkov <bp@alien8.de> - 2016-08-09 07:10 +0200
        Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 Borislav Petkov <bp@alien8.de> - 2016-08-09 09:00 +0200
          Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 Borislav Petkov <bp@alien8.de> - 2016-08-09 19:00 +0200
          Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 york sun <york.sun@nxp.com> - 2016-08-09 19:20 +0200
          Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 york sun <york.sun@nxp.com> - 2016-08-09 19:40 +0200
        Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 york sun <york.sun@nxp.com> - 2016-08-09 12:40 +0200
      Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing  RFXE bit in HID1 york sun <york.sun@nxp.com> - 2016-08-09 10:10 +0200

csiph-web