Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1458369

Re: [PATCH] megaraid_sas: Fix probing cards without io port

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] megaraid_sas: Fix probing cards without io port
Date Tue, 09 Aug 2016 04:10:01 +0200
Message-ID <s44Ep-1hp-3@gated-at.bofh.it> (permalink)
References <s3g4W-1Yq-65@gated-at.bofh.it>
X-Original-To Yinghai Lu <yinghai@kernel.org>
Organization Oracle Corporation
User-Agent Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version 1.0
Content-Type text/plain
X-Source-IP aserv0021.oracle.com [141.146.126.233]
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
X-Original-Cc Kashyap Desai <kashyap.desai@avagotech.com>, Sumit Saxena <sumit.saxena@avagotech.com>, Uday Lingala <uday.lingala@avagotech.com>, "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Mon, 08 Aug 2016 22:03:06 -0400
X-Original-Message-ID <yq1bn12u2at.fsf@sermon.lab.mkp.net>
X-Original-References <20160806063734.31083-1-yinghai@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1458369

Show key headers only | View raw


>>>>> "Yinghai" == Yinghai Lu <yinghai@kernel.org> writes:

> Found one megaraid_sas HBA probe fails,
> 
> [  187.235190] scsi host2: Avago SAS based MegaRAID driver
> [  191.112365] megaraid_sas 0000:89:00.0: BAR 0: can't reserve [io  0x0000-0x00ff]
> [  191.120548] megaraid_sas 0000:89:00.0: IO memory region busy!

> and the card has resource like,
> [  125.097714] pci 0000:89:00.0: [1000:005d] type 00 class 0x010400
> [  125.104446] pci 0000:89:00.0: reg 0x10: [io  0x0000-0x00ff]
> [  125.110686] pci 0000:89:00.0: reg 0x14: [mem 0xce400000-0xce40ffff 64bit]
> [  125.118286] pci 0000:89:00.0: reg 0x1c: [mem 0xce300000-0xce3fffff 64bit]
> [  125.125891] pci 0000:89:00.0: reg 0x30: [mem 0xce200000-0xce2fffff pref]

> that does not io port resource allocated from BIOS, and kernel can not assign
> one as io port shortage.
> 
> The driver is only looking for MEM, and should not fail.

> It turns out megasas_init_fw() etc are using bar index as mask.
> index 1 is used as mask 1, so that pci_request_selected_regions()
> is trying to request BAR0 instead of BAR1.

> Fix all related reference.

Kashyap? Sumit?

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] megaraid_sas: Fix probing cards without io port Yinghai Lu <yinghai@kernel.org> - 2016-08-06 22:10 +0200
  Re: [PATCH] megaraid_sas: Fix probing cards without io port "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-08-09 04:10 +0200
    RE: [PATCH] megaraid_sas: Fix probing cards without io port Kashyap Desai <kashyap.desai@broadcom.com> - 2016-08-09 20:00 +0200

csiph-web