Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458254

[PATCH v2 2/6] staging/android: do not let userspace trigger WARN_ON

Show all headers | View raw

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Closing the timeline without waiting all fences to signal is not
a critical failure, it is just bad usage from userspace so avoid
calling WARN_ON in this case.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
 drivers/staging/android/sw_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c
index b4ae092..ad0bb1a 100644
--- a/drivers/staging/android/sw_sync.c
+++ b/drivers/staging/android/sw_sync.c
@@ -150,7 +150,7 @@ static void timeline_fence_release(struct fence *fence)
 
 	spin_lock_irqsave(fence->lock, flags);
 	list_del(&pt->child_list);
-	if (WARN_ON_ONCE(!list_empty(&pt->active_list)))
+	if (!list_empty(&pt->active_list))
 		list_del(&pt->active_list);
 	spin_unlock_irqrestore(fence->lock, flags);
 
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] de-stage SW_SYNC validation frawework Gustavo Padovan <gustavo@padovan.org> - 2016-08-08 23:30 +0200
  [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h Gustavo Padovan <gustavo@padovan.org> - 2016-08-08 23:30 +0200
  [PATCH v2 2/6] staging/android: do not let userspace trigger WARN_ON Gustavo Padovan <gustavo@padovan.org> - 2016-08-08 23:30 +0200
  [PATCH v2 1/6] staging/android: remove doc from sw_sync Gustavo Padovan <gustavo@padovan.org> - 2016-08-08 23:30 +0200
    Re: [PATCH v2 1/6] staging/android: remove doc from sw_sync Pavel Machek <pavel@ucw.cz> - 2016-08-10 20:30 +0200

csiph-web